Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][doc] Default behaviour with acknowledge timeout #18436

Merged
merged 2 commits into from
Nov 12, 2022

Conversation

AlvaroStream
Copy link
Contributor

For newcomers this is a question it can be important.

It is mentioned here

Motivation

The documentation was lacking this default as a note.

Modifications

Added the information in case somebody forgets to configure ackTimeOut.

Verifying this change

  • [ X ] Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Nov 11, 2022
@codelipenghui codelipenghui merged commit fdf86d3 into apache:master Nov 12, 2022
@AlvaroStream AlvaroStream deleted the patch-7 branch November 14, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants