-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Avoid object create in RedeliveryTracker.getRedeliveryCount
#18352
Merged
codelipenghui
merged 2 commits into
apache:master
from
lifepuzzlefun:improve_redelivery_count_in_tracer
Nov 11, 2022
Merged
[improve][broker] Avoid object create in RedeliveryTracker.getRedeliveryCount
#18352
codelipenghui
merged 2 commits into
apache:master
from
lifepuzzlefun:improve_redelivery_count_in_tracer
Nov 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion)` to `RedeliveryTracker.getRedeliveryCount(long ledgerId, long entryId)` with this replace we can remove the unnessary PositionImpl object creation.
poorbarcode
approved these changes
Nov 7, 2022
Technoboy-
changed the title
[cleanup] avoid object create in
[cleanup][broker] Avoid object create in Nov 8, 2022
RedeliveryTracker.getRedeliveryCount
RedeliveryTracker.getRedeliveryCount
Technoboy-
added
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
area/broker
ready-to-test
labels
Nov 8, 2022
Technoboy-
changed the title
[cleanup][broker] Avoid object create in
[improve][broker] Avoid object create in Nov 8, 2022
RedeliveryTracker.getRedeliveryCount
RedeliveryTracker.getRedeliveryCount
Technoboy-
approved these changes
Nov 8, 2022
@WJL3333 You can trigger CI through |
Codecov Report
@@ Coverage Diff @@
## master #18352 +/- ##
============================================
+ Coverage 40.29% 47.13% +6.84%
- Complexity 8685 10385 +1700
============================================
Files 687 692 +5
Lines 67441 67765 +324
Branches 7225 7258 +33
============================================
+ Hits 27175 31943 +4768
+ Misses 37257 32253 -5004
- Partials 3009 3569 +560
Flags with carried forward coverage won't be shown. Click here to find out more.
|
codelipenghui
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
doc-not-needed
Your PR changes do not impact docs
ready-to-test
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18353
Motivation
PositionImpl object is just use to pass parameter which can be avoid by direct pass.
Modifications
change method signature
RedeliveryTracker.getRedeliveryCount
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete