-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][client] Fix exception when calling loadConf on a ConsumerBuilder that has a KeySharedPolicy #18345
Merged
codelipenghui
merged 1 commit into
apache:master
from
cbornet:fix-keysharedpolicy-loadconf
Nov 16, 2022
Merged
[fix][client] Fix exception when calling loadConf on a ConsumerBuilder that has a KeySharedPolicy #18345
codelipenghui
merged 1 commit into
apache:master
from
cbornet:fix-keysharedpolicy-loadconf
Nov 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbornet
changed the title
Fix exception when calling loadConf on a ConsumerBuilder that has a KeySharedPolicy
[fix][client] Fix exception when calling loadConf on a ConsumerBuilder that has a KeySharedPolicy
Nov 4, 2022
…eySharedPolicy The exception occurs because KeySharedPolicy can't be deserialized. This change also adds unit tests for loadConf
cbornet
force-pushed
the
fix-keysharedpolicy-loadconf
branch
from
November 4, 2022 15:34
ad5b252
to
376f413
Compare
14 tasks
Codecov Report
@@ Coverage Diff @@
## master #18345 +/- ##
============================================
+ Coverage 40.29% 47.25% +6.95%
- Complexity 8685 10370 +1685
============================================
Files 687 687
Lines 67441 67437 -4
Branches 7225 7226 +1
============================================
+ Hits 27175 31865 +4690
+ Misses 37257 31996 -5261
- Partials 3009 3576 +567
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eolivelli
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
codelipenghui
approved these changes
Nov 16, 2022
codelipenghui
added
type/bug
The PR fixed a bug or issue reported a bug
area/client
release/2.9.4
release/2.11.1
release/2.10.3
labels
Nov 16, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 10, 2023
…r that has a KeySharedPolicy (apache#18345) (cherry picked from commit 9c2ec5e) (cherry picked from commit 5e8a213)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 11, 2023
…r that has a KeySharedPolicy (apache#18345) (cherry picked from commit 9c2ec5e) (cherry picked from commit 5e8a213)
4 tasks
Technoboy-
pushed a commit
that referenced
this pull request
Feb 8, 2023
…r that has a KeySharedPolicy (#18345)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/client
cherry-picked/branch-2.9
Archived: 2.9 is end of life
cherry-picked/branch-2.10
cherry-picked/branch-2.11
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/2.9.4
release/2.10.3
release/2.11.1
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The exception occurs because
KeySharedPolicy
can't be deserialized.This change also adds unit tests for
loadConf
Modifications
Add
JsonIgnore
onConsumerBuilder
'skeySharedPolicy
field.Verifying this change
This change added tests and can be verified as follows:
ConsumerBuilderImplTest::testLoadConf
andConsumerBuilderImplTest::testLoadConfNotModified
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: cbornet#6