Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup][broker] Remove legacy code #18330

Merged
merged 1 commit into from
Nov 19, 2022
Merged

Conversation

aloyszhang
Copy link
Contributor

@aloyszhang aloyszhang commented Nov 4, 2022

Motivation

remove legacy code

Modifications

remove legacy code

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • doc-not-needed

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

@aloyszhang Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Nov 4, 2022
@aloyszhang aloyszhang changed the title remove legacy code [cleanup][broker]remove legacy code Nov 4, 2022
@codelipenghui codelipenghui added this to the 2.12.0 milestone Nov 10, 2022
@codelipenghui codelipenghui added type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use area/broker labels Nov 10, 2022
@codelipenghui
Copy link
Contributor

/pulsarbot run-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022

Codecov Report

Merging #18330 (62f4a6a) into master (8b404d4) will decrease coverage by 2.01%.
The diff coverage is 6.12%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18330      +/-   ##
============================================
- Coverage     47.15%   45.13%   -2.02%     
- Complexity    10432    10630     +198     
============================================
  Files           697      758      +61     
  Lines         68023    72738    +4715     
  Branches       7284     7804     +520     
============================================
+ Hits          32074    32831     +757     
- Misses        32367    36213    +3846     
- Partials       3582     3694     +112     
Flag Coverage Δ
unittests 45.13% <6.12%> (-2.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rg/apache/pulsar/broker/service/AbstractTopic.java 65.45% <ø> (+0.58%) ⬆️
...he/pulsar/client/impl/MultiTopicsConsumerImpl.java 22.98% <0.00%> (+0.71%) ⬆️
...n/java/org/apache/pulsar/client/util/NoOpLock.java 0.00% <0.00%> (ø)
...va/org/apache/pulsar/client/impl/ConsumerImpl.java 15.12% <7.69%> (+0.28%) ⬆️
...va/org/apache/pulsar/client/impl/ConsumerBase.java 21.93% <16.66%> (-0.02%) ⬇️
.../transaction/buffer/metadata/AbortTxnMetadata.java 28.57% <0.00%> (-57.15%) ⬇️
...ion/buffer/metadata/TransactionBufferSnapshot.java 42.85% <0.00%> (-42.86%) ⬇️
...saction/timeout/TransactionTimeoutTrackerImpl.java 50.87% <0.00%> (-36.85%) ⬇️
...oker/loadbalance/LoadResourceQuotaUpdaterTask.java 44.44% <0.00%> (-33.34%) ⬇️
...er/impl/SingleSnapshotAbortedTxnProcessorImpl.java 51.19% <0.00%> (-29.77%) ⬇️
... and 117 more

@Technoboy- Technoboy- changed the title [cleanup][broker]remove legacy code [cleanup][broker] Remove legacy code Nov 19, 2022
@Technoboy- Technoboy- closed this Nov 19, 2022
@Technoboy- Technoboy- reopened this Nov 19, 2022
@Technoboy- Technoboy- merged commit 74a498a into apache:master Nov 19, 2022
@aloyszhang aloyszhang deleted the rm-legacy branch November 30, 2022 01:44
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker doc-not-needed Your PR changes do not impact docs ready-to-test type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants