-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cleanup][broker] Remove legacy code #18330
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@aloyszhang Please add the following content to your PR description and select a checkbox:
|
github-actions
bot
added
doc-not-needed
Your PR changes do not impact docs
and removed
doc-label-missing
labels
Nov 4, 2022
codelipenghui
approved these changes
Nov 10, 2022
codelipenghui
added
type/cleanup
Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
area/broker
labels
Nov 10, 2022
/pulsarbot run-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #18330 +/- ##
============================================
- Coverage 47.15% 45.13% -2.02%
- Complexity 10432 10630 +198
============================================
Files 697 758 +61
Lines 68023 72738 +4715
Branches 7284 7804 +520
============================================
+ Hits 32074 32831 +757
- Misses 32367 36213 +3846
- Partials 3582 3694 +112
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
changed the title
[cleanup][broker]remove legacy code
[cleanup][broker] Remove legacy code
Nov 19, 2022
Technoboy-
force-pushed
the
rm-legacy
branch
from
November 19, 2022 04:14
c421939
to
62f4a6a
Compare
Technoboy-
approved these changes
Nov 19, 2022
tisonkun
approved these changes
Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
doc-not-needed
Your PR changes do not impact docs
ready-to-test
type/cleanup
Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
remove legacy code
Modifications
remove legacy code
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Documentation
doc-not-needed