-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][client] Fix NPE of MultiTopicsConsumerImpl due to race condition #18287
Merged
codelipenghui
merged 1 commit into
apache:master
from
codelipenghui:penghui/fix-race-multiple-consumer
Nov 2, 2022
Merged
[fix][client] Fix NPE of MultiTopicsConsumerImpl due to race condition #18287
codelipenghui
merged 1 commit into
apache:master
from
codelipenghui:penghui/fix-race-multiple-consumer
Nov 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
added
type/bug
The PR fixed a bug or issue reported a bug
area/client
release/2.9.4
release/2.11.1
release/2.10.3
labels
Nov 1, 2022
codelipenghui
requested review from
eolivelli,
mattisonchao,
merlimat,
michaeljmarshall and
Technoboy-
November 1, 2022 14:12
mattisonchao
approved these changes
Nov 2, 2022
/pulsarbot run-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #18287 +/- ##
============================================
- Coverage 38.97% 38.16% -0.81%
+ Complexity 8311 8014 -297
============================================
Files 683 659 -24
Lines 67325 65091 -2234
Branches 7217 6972 -245
============================================
- Hits 26239 24845 -1394
+ Misses 38079 37410 -669
+ Partials 3007 2836 -171
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Nov 2, 2022
poorbarcode
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Catch!!!
Technoboy-
pushed a commit
that referenced
this pull request
Nov 2, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 9, 2022
apache#18287) (cherry picked from commit 516db51) (cherry picked from commit cc53bd3)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/client
cherry-picked/branch-2.9
Archived: 2.9 is end of life
cherry-picked/branch-2.10
cherry-picked/branch-2.11
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/2.9.4
release/2.10.3
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The stack trace is based on 2.9.2
The close and unsubscribe operation will change the
unAckedMessageTracker
to null which will cause the above problem.Modifications
We should stop processing messages after the consumer is closed.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete