[improve][broker] Optimize the log printing of PulsarService #18244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnonHxy
reviewed
Oct 28, 2022
| LOG.info("messaging service is ready, bootstrap_seconds={}", bootstrapTimeSeconds); | ||
| LOG.info("messaging service is ready, {}, cluster={}, configs={}", bootstrapMessage, | ||
| config.getClusterName(), config); | ||
| LOG.info("messaging service is ready, {}, cluster={}, configs={}, bootstrap_seconds={}", bootstrapMessage, |
There was a problem hiding this comment.
It's better move the bootstrap_seconds to first position, because the configs will be very long
There was a problem hiding this comment.
@codelipenghui @AnonHxy I have updated, PTAL.
AnonHxy
changed the title
AnonHxy
added
the
type/enhancement
added 2 commits
October 29, 2022 16:41
Pomelongan
force-pushed
the
update_PulsarService
branch
from
2ec2dbf to
75e867a
Compare
tisonkun
approved these changes
Oct 29, 2022
AnonHxy
approved these changes
Oct 30, 2022
codelipenghui
approved these changes
Oct 31, 2022
Codecov Report
@@ Coverage Diff @@
## master #18244 +/- ##
=============================================
+ Coverage 38.84% 49.48% +10.64%
+ Complexity 8286 6999 -1287
=============================================
Files 683 398 -285
Lines 67323 43587 -23736
Branches 7215 4475 -2740
=============================================
- Hits 26152 21570 -4582
+ Misses 38210 19634 -18576
+ Partials 2961 2383 -578
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In
org.apache.pulsar.broker.PulsarService#start, two log printing can be combined into one line.pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
Lines 905 to 907 in b7b9239
Modifications
Combine the two log lines in the
org.apache.pulsar.broker.PulsarService#startinto one line.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: Pomelongan#11