[fix][admin] Passing force parameter to deleteNamespaceBundle when deleting namespaces
#18153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
force-pushed
the
fix_force_deletenaspace
branch
from
426c515 to
973f3f9
Compare
coderzc
force-pushed
the
fix_force_deletenaspace
branch
from
973f3f9 to
20f2bb6
Compare
nodece
approved these changes
Oct 21, 2022
Technoboy-
approved these changes
Oct 22, 2022
Technoboy-
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #18153 +/- ##
============================================
+ Coverage 34.91% 39.94% +5.03%
- Complexity 5707 14899 +9192
============================================
Files 607 1574 +967
Lines 53396 128632 +75236
Branches 5712 14159 +8447
============================================
+ Hits 18644 51385 +32741
- Misses 32119 71497 +39378
- Partials 2633 5750 +3117
Flags with carried forward coverage won't be shown. Click here to find out more.
|
codelipenghui
approved these changes
Oct 24, 2022
AnonHxy
approved these changes
Oct 24, 2022
|
/pulsarbot run-failure-checks |
RobertIndie
approved these changes
Oct 24, 2022
momo-jun
changed the title
force parameter to deleteNamespaceBundle when delete namespacesforce parameter to deleteNamespaceBundle when deleting namespaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the current implementation, don't pass the
forceparameter todeleteNamespaceBundlewhen deleting namespaces, we should pass theforceparameter.Modifications
Passing
forceparameter todeleteNamespaceBundlewhen delete namespaces.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: coderzc#20