Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][ci] Add zk and bk for semantic check #18096

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

michaeljmarshall
Copy link
Member

Motivation

It seems we missed zookeeper and bookkeeper in the scopes. This PR adds them.

Documentation

  • doc-not-needed

@michaeljmarshall michaeljmarshall added doc-not-needed Your PR changes do not impact docs area/ci labels Oct 18, 2022
@michaeljmarshall michaeljmarshall added this to the 2.12.0 milestone Oct 18, 2022
@michaeljmarshall michaeljmarshall self-assigned this Oct 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022

Codecov Report

Merging #18096 (fe14b9a) into master (6c65ca0) will increase coverage by 10.93%.
The diff coverage is 52.99%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #18096       +/-   ##
=============================================
+ Coverage     34.91%   45.85%   +10.93%     
- Complexity     5707    17592    +11885     
=============================================
  Files           607     1574      +967     
  Lines         53396   128338    +74942     
  Branches       5712    14121     +8409     
=============================================
+ Hits          18644    58844    +40200     
- Misses        32119    63402    +31283     
- Partials       2633     6092     +3459     
Flag Coverage Δ
unittests 45.85% <52.99%> (+10.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...org/apache/pulsar/broker/ServiceConfiguration.java 52.07% <ø> (ø)
.../pulsar/broker/service/AbstractBaseDispatcher.java 51.92% <ø> (+6.06%) ⬆️
.../service/SystemTopicBasedTopicPoliciesService.java 61.39% <0.00%> (+9.80%) ⬆️
.../pulsar/broker/stats/BrokerOperabilityMetrics.java 98.21% <ø> (+5.56%) ⬆️
...g/apache/pulsar/compaction/CompactedTopicImpl.java 69.28% <0.00%> (+58.57%) ⬆️
...va/org/apache/pulsar/client/impl/ConsumerBase.java 21.95% <0.00%> (ø)
...ache/pulsar/functions/utils/io/ConnectorUtils.java 0.00% <0.00%> (ø)
...va/org/apache/pulsar/io/jdbc/JdbcAbstractSink.java 4.16% <0.00%> (-0.03%) ⬇️
...java/org/apache/pulsar/io/jdbc/JdbcSinkConfig.java 23.33% <0.00%> (-1.67%) ⬇️
...main/java/org/apache/pulsar/io/jdbc/JdbcUtils.java 0.00% <0.00%> (ø)
... and 1131 more

@nodece
Copy link
Member

nodece commented Oct 20, 2022

The storage scope should include zk and bk.

Copy link
Member

@dave2wave dave2wave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dave2wave dave2wave merged commit 330654a into apache:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants