[fix][sec] Upgrade commons-text to 1.10.0 in the kinesis-sink #18093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoloboschi
commented
Oct 18, 2022
| @@ -65,13 +65,6 @@ | |||
| <skip>true</skip> | |||
| </configuration> | |||
| </plugin> | |||
| <plugin> | |||
There was a problem hiding this comment.
useless, it throws warning for the missing version
There was a problem hiding this comment.
please make the patch focus only on one problem (the upgrade)
nicoloboschi
commented
Oct 18, 2022
nicoloboschi
requested review from
eolivelli and
nodece
and removed request for
eolivelli
|
@coderzc PTAL |
nicoloboschi
added a commit
to datastax/pulsar
that referenced
this pull request
Oct 18, 2022
Codecov Report
@@ Coverage Diff @@
## master #18093 +/- ##
=============================================
+ Coverage 34.91% 51.07% +16.15%
- Complexity 5707 8755 +3048
=============================================
Files 607 607
Lines 53396 53511 +115
Branches 5712 5739 +27
=============================================
+ Hits 18644 27329 +8685
+ Misses 32119 23135 -8984
- Partials 2633 3047 +414
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eolivelli
requested changes
Oct 20, 2022
| @@ -65,13 +65,6 @@ | |||
| <skip>true</skip> | |||
| </configuration> | |||
| </plugin> | |||
| <plugin> | |||
There was a problem hiding this comment.
please make the patch focus only on one problem (the upgrade)
Technoboy-
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow up of #18053.
Kinesis sink still uses 1.9
Modifications
commons-textdependency to the dependency management sectionDocumentation
docdoc-requireddoc-not-neededdoc-complete