-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][ci] Add ml
for CI semantic check.
#18082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
managed-ledger should be covered by storage
already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can I tell ml
and storage
?
I prefer using |
Codecov Report
@@ Coverage Diff @@
## master #18082 +/- ##
=============================================
+ Coverage 34.91% 46.85% +11.93%
- Complexity 5707 17876 +12169
=============================================
Files 607 1574 +967
Lines 53396 128320 +74924
Branches 5712 14116 +8404
=============================================
+ Hits 18644 60122 +41478
- Misses 32119 61973 +29854
- Partials 2633 6225 +3592
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@lhotari could you answer the question above? Doesn't storage scope already cover If it's the case, we should revert this patch. |
We'd better define these by modules. |
@Technoboy- then what kind of changes should go into Besides, |
Motivation
As some patches(like #18078 ) are only for managed-ledger, so add this label.
Documentation
doc
doc-required
doc-not-needed
doc-complete