[fix][py] Correct configuration of pattern discovery period #17912
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the
pattern_auto_discovery_period
for topic pattern consumers is fixed to 60 seconds, no matter what is passed into thesubscribe
function. This is a fix for that bug.Modifications
Pattern discovery period configuration is now passed through correctly from the
subscribe
function.New test to exercise pattern discovery.
Removed misleading configuration in other test which does not use automated pattern discovery.
Made log level configurable in test file with environment variable.
If the changes are ok, I can backport these changes to earlier branches - we use v2.9 currently so I have a specific requirement for that version. I can also open a PR against the new v3 repository if required.
Verifying this change
Make sure that the change passes the CI checks.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
Documentation now matches behaviour described for the
pattern_auto_discovery_period
option.doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)
Matching PR in forked repository
PR in forked repository:
Successful manual run of CI job in forked repository