[ci] Verify checkstyle and spotbugs for all modules #17858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hezhangjian
approved these changes
Sep 27, 2022
lhotari
reviewed
Sep 27, 2022
|
|
||
| - name: Build core-modules | ||
| run: | | ||
| mvn -B -T 1C -ntp -Pcore-modules,-main clean install -DskipTests -Dlicense.skip=true -Drat.skip=true | ||
| mvn -B -T 1C -ntp -Pcore-modules,-main clean install -DskipTests -Dlicense.skip=true -Drat.skip=true -Dcheckstyle.skip -Dspotbugs.skip |
There was a problem hiding this comment.
the syntax for skipping doesn't look right. I'd assume -Dspotbugs.skip=true. Please validate locally that the commands do what is expected.
There was a problem hiding this comment.
I usually use that syntax locally
lhotari
reviewed
Sep 27, 2022
|
|
||
| - name: Build core-modules | ||
| run: | | ||
| mvn -B -T 1C -ntp -Pcore-modules,-main clean install -DskipTests -Dlicense.skip=true -Drat.skip=true | ||
| mvn -B -T 1C -ntp -Pcore-modules,-main clean install -DskipTests -Dlicense.skip=true -Drat.skip=true -Dcheckstyle.skip -Dspotbugs.skip |
There was a problem hiding this comment.
Suggested change
| mvn -B -T 1C -ntp -Pcore-modules,-main clean install -DskipTests -Dlicense.skip=true -Drat.skip=true -Dcheckstyle.skip -Dspotbugs.skip | |
| mvn -B -T 1C -ntp -Pcore-modules,-main clean install -DskipTests -Dlicense.skip=true -Drat.skip=true -Dcheckstyle.skip=true -Dspotbugs.skip=true |
|
the problem is that checkstyle and spotbugs are not enabled in all the projects. |
Yes. This can be a root build plugin. |
|
Closing due to #18142 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#17750 changes don't pass checkstyle check on a non core module. CI didn't fail because we don't check checkstyle on those modules.
Modifications
doc-not-needed