[feature][broker] Support autoSubscriptionCreation on topic level
#17720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuruguo
changed the title
autoSubscriptionCreation on topic level
yuruguo
requested review from
mattisonchao,
AnonHxy,
codelipenghui,
Jason918 and
Technoboy-
yuruguo
added
type/feature
AnonHxy
reviewed
Sep 30, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Show resolved
Hide resolved
Jason918
reviewed
Oct 31, 2022
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/TopicPolicies.java
Show resolved
Hide resolved
Jason918
reviewed
Nov 1, 2022
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/HierarchyTopicPolicies.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #17720 +/- ##
=========================================
Coverage ? 23.64%
Complexity ? 4757
=========================================
Files ? 685
Lines ? 67385
Branches ? 7218
=========================================
Hits ? 15930
Misses ? 49096
Partials ? 2359
Flags with carried forward coverage won't be shown. Click here to find out more. |
Jason918
approved these changes
Nov 2, 2022
AnonHxy
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Current pulsar only support to set
autoSubscriptionCreationon broker and namespace level, but we can further set this policy on the topic level.Modifications
handleSubscribein ServerCnx need to check autoSubscriptionCreation policy of topicDocumentation
doc-not-neededMatching PR in forked repository
PR in forked repository: