-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][docs] Get started locally #17475
[improve][docs] Get started locally #17475
Conversation
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
There are some back links to install connectors and offloaders. I'll resolve them separately in another PR. |
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove bin/pulsar-daemon start standalone
part? Is it a rare use case?
Thanks for your contribution! Feel free to correct me if my understanding is inaccurate. |
@D-2-Ed any thoughts on this? Thank you! |
Co-authored-by: Anonymitaet <[email protected]>
Co-authored-by: Anonymitaet <[email protected]>
Co-authored-by: Anonymitaet <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
@Anonymitaet thanks for your reviews! Comments addressed. |
You're right that we can add back the tip. Updated. |
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Have you previewed your changes to ensure everything goes as expected?
If not yet, please preview your changes locally and attach the screenshots in the PR description to let others know. In this way, you can get your PR merged more quickly. Thanks!
Aha, I preview each change in batch. It's OK that I attach some screenshots. I didn't do it in the first place because it's almost a new page longer than one screen and I'd prefer the reviewers can preview themselves. Also, it's easily outdated as the review is in progress. |
Signed-off-by: tison <[email protected]>
@Anonymitaet Uploaded previews here: |
Signed-off-by: tison <[email protected]>
@tisonkun thanks! Feel free to ping me to merge this PR after all tests pass. |
This patch should be ready to merge. cc @Anonymitaet @momo-jun @RobertIndie |
Fixes #17409.
For description, read the issue description and these two comments: #17409 (comment) + #17409 (comment).
doc
cc @Anonymitaet @momo-jun @DaveDuggins @labuladong @merlimat @TheYonk