-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Streaming dispatcher stuck after reading the first entry with SHARED subscriptions #17143
[fix][broker] Streaming dispatcher stuck after reading the first entry with SHARED subscriptions #17143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great catch !
Hi @nicoloboschi It looks like it just affects 2.11 and master. Because of the previous branch, we use this PR https://github.com/apache/pulsar/pull/17053/files to cherry-pick. Another concern is why we don't have the test to verify it. :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, and thanks to you!
I will try to move the |
…y with SHARED subscriptions (#17143)
NOTE: THIS BUG IS NOT IN ANY RELEASED VERSION OF PULSAR.
Motivation
While using a streaming dispatcher (
streamingDispatch=true
), the consumer (with a shared subscription) is stuck and it's not able to fully read a topic. That is because after the an entry is read, thereadMoreEntries
method is not triggered anymore. This is a regression introduced in #16968Modifications
sendMessagesToConsumers
in thePersistentStreamingDispatcherMultipleConsumers
in the same way it's used inPersistentDispatcherMultipleConsumers
DispatcherDispatchMessagesInSubscriptionThread
also in the streaming dispatcher - this might be done in another pull but it's a very tiny change - follow up of [enh] Broker - Shared subscription: run filters in a separate (per-subscription) thread (dispatcherDispatchMessagesInSubscriptionThread) #16603The evidence of this bug is that the test a several tests with streaming enabled are failing but since they are in the flaky section, they have been ignored. Now these tests are passing
doc-not-needed