Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Streaming dispatcher stuck after reading the first entry with SHARED subscriptions #17143

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

nicoloboschi
Copy link
Contributor

@nicoloboschi nicoloboschi commented Aug 17, 2022

NOTE: THIS BUG IS NOT IN ANY RELEASED VERSION OF PULSAR.

Motivation

While using a streaming dispatcher (streamingDispatch=true), the consumer (with a shared subscription) is stuck and it's not able to fully read a topic. That is because after the an entry is read, the readMoreEntries method is not triggered anymore. This is a regression introduced in #16968

Modifications

The evidence of this bug is that the test a several tests with streaming enabled are failing but since they are in the flaky section, they have been ignored. Now these tests are passing

  • doc-not-needed

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch !

@eolivelli eolivelli added the release/blocker Indicate the PR or issue that should block the release until it gets resolved label Aug 17, 2022
@Technoboy- Technoboy- modified the milestones: 2.12.0, 2.11.0 Aug 17, 2022
@mattisonchao
Copy link
Member

Hi @nicoloboschi
I'm sorry for missing the PersistentStreamingDispatcherMultipleConsumers. And thanks to your point out.

It looks like it just affects 2.11 and master. Because of the previous branch, we use this PR https://github.com/apache/pulsar/pull/17053/files to cherry-pick.

Another concern is why we don't have the test to verify it. :(

Copy link
Member

@mattisonchao mattisonchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, and thanks to you!

@mattisonchao
Copy link
Member

I will try to move the StreamingDispather relative test out of the flaky group. Plus, I will remove the label release/2.8.5, release/2.9.4 and release/2.10.2 because we don't need to cherry-pick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.11 release/blocker Indicate the PR or issue that should block the release until it gets resolved release/2.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants