Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup][transaction] Add Maven Modernizer plugin in pulsar-transaction #16964

Merged
merged 2 commits into from
Aug 7, 2022

Conversation

youzipi
Copy link
Contributor

@youzipi youzipi commented Aug 6, 2022

Motivation

Master Issue: #12271

Apply Maven Modernizer plugin to enforce we move away from legacy APIs.

Modifications

Add Maven Modernizer plugin in pulsar-transaction module and fix violation.

Verifying this change

This change is already covered by existing tests, such as (please describe tests).

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • doc-not-needed

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Aug 6, 2022
@youzipi youzipi changed the title [Issue 12271][Modernizer] Add Maven Modernizer plugin in pulsar-trans… [WIP][Issue 12271][Modernizer] Add Maven Modernizer plugin in pulsar-trans… Aug 6, 2022
@youzipi youzipi changed the title [WIP][Issue 12271][Modernizer] Add Maven Modernizer plugin in pulsar-trans… [Issue 12271][Modernizer] Add Maven Modernizer plugin in pulsar-trans… Aug 6, 2022
@youzipi
Copy link
Contributor Author

youzipi commented Aug 7, 2022

/pulsarbot run-failure-checks

@codelipenghui codelipenghui added this to the 2.12.0 milestone Aug 7, 2022
@codelipenghui codelipenghui changed the title [Issue 12271][Modernizer] Add Maven Modernizer plugin in pulsar-trans… [cleanup][transaction] Add Maven Modernizer plugin in pulsar-transaction Aug 7, 2022
@codelipenghui codelipenghui merged commit edcf67a into apache:master Aug 7, 2022
@codelipenghui codelipenghui added type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use area/transaction labels Aug 7, 2022
@youzipi youzipi deleted the modernizer-maven branch August 7, 2022 07:24
@Technoboy- Technoboy- modified the milestones: 2.12.0, 2.11.0 Aug 8, 2022
Technoboy- pushed a commit to merlimat/pulsar that referenced this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/transaction doc-not-needed Your PR changes do not impact docs type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants