-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][doc] Add doc of reader config to pulsar-io-debezium
#16891
[improve][doc] Add doc of reader config to pulsar-io-debezium
#16891
Conversation
@@ -27,7 +27,9 @@ The configuration of Debezium source connector has the following properties. | |||
| `database.history.pulsar.topic` | true | null | The name of the database history topic where the connector writes and recovers DDL statements. <br /><br />**Note: this topic is for internal use only and should not be used by consumers.** | | |||
| `database.history.pulsar.service.url` | true | null | Pulsar cluster service URL for history topic. | | |||
| `offset.storage.topic` | true | null | Record the last committed offsets that the connector successfully completes. | | |||
| `json-with-envelope` | false | false | Present the message only consist of payload. | |||
| `json-with-envelope` | false | false | Present the message only consist of payload. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `json-with-envelope` | false | false | Present the message only consist of payload. | | |
| `json-with-envelope` | false | false | Present the message that consists of payload only. | |
Is this what it means? The original one has a grammar issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@freeznet thanks for adding the docs. I left several minor suggestions.
Another concern is the historical doc versions you changed is 2.9.3 and 2.10.1 while the code PR seems to serve 2.9.4 and 2.10.2?
Co-authored-by: momo-jun <[email protected]>
Co-authored-by: momo-jun <[email protected]>
In the current practice of Pulsar doc release and maintenance, the docs for the upcoming 2.9.4 and 2.10.2 releases aren't in place until the release is ready to announce. Since PIP-190 has been adopted, I'm generating 2.9.x and 2.10.x docs in #17074. You can leave them as they are in this PR and I will sync your changes there. |
The pr had no activity for 30 days, mark with Stale label. |
Fixes #16674
Motivation
Add doc for #16675
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)