Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][functions] Missing assertion in KubernetesRuntimeTest::verifyJavaInstance #16747

Merged
merged 1 commit into from
Aug 3, 2022
Merged

[improve][functions] Missing assertion in KubernetesRuntimeTest::verifyJavaInstance #16747

merged 1 commit into from
Aug 3, 2022

Conversation

cbornet
Copy link
Contributor

@cbornet cbornet commented Jul 22, 2022

Motivation

The assertion in KubernetesRuntimeTest::verifyJavaInstance was removed by accident in #11417

Modifications

Put back the assertEquals

Verifying this change

  • Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as KubernetesRuntimeTest

Does this pull request potentially affect one of the following parts:

no

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    test

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 22, 2022
@cbornet
Copy link
Contributor Author

cbornet commented Jul 23, 2022

/pulsarbot rerun-failure-checks

4 similar comments
@cbornet
Copy link
Contributor Author

cbornet commented Jul 25, 2022

/pulsarbot rerun-failure-checks

@cbornet
Copy link
Contributor Author

cbornet commented Jul 25, 2022

/pulsarbot rerun-failure-checks

@cbornet
Copy link
Contributor Author

cbornet commented Jul 25, 2022

/pulsarbot rerun-failure-checks

@cbornet
Copy link
Contributor Author

cbornet commented Jul 26, 2022

/pulsarbot rerun-failure-checks

@cbornet cbornet force-pushed the kerbernetes-runtime-test branch from 48e02e8 to dabde82 Compare July 27, 2022 07:35
@cbornet
Copy link
Contributor Author

cbornet commented Jul 27, 2022

/pulsarbot rerun-failure-checks

1 similar comment
@cbornet
Copy link
Contributor Author

cbornet commented Jul 28, 2022

/pulsarbot rerun-failure-checks

@Technoboy- Technoboy- added this to the 2.11.0 milestone Aug 3, 2022
@Technoboy- Technoboy- closed this Aug 3, 2022
@Technoboy- Technoboy- reopened this Aug 3, 2022
@Technoboy- Technoboy- merged commit 5c8c86d into apache:master Aug 3, 2022
@cbornet cbornet deleted the kerbernetes-runtime-test branch August 3, 2022 11:31
Technoboy- pushed a commit to merlimat/pulsar that referenced this pull request Aug 16, 2022
@cbornet @Technoboy-
Missing assertion in KubernetesRuntimeTest::verifyJavaInstance (apach…
7284795 
…e#16747)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@freeznet freeznet freeznet approved these changes

Assignees

@cbornet cbornet

Labels
doc-not-needed Your PR changes do not impact docs type/flaky-tests
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cbornet @freeznet @Technoboy-