[fix][doc] Enable zk when starting standalone in pulsar-sql doc #16369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertIndie
added
doc
MarvinCai
approved these changes
Jul 4, 2022
RobertIndie
force-pushed
the
fix-pulsar-sql-doc
branch
from
85486a7
to
e943010
Compare
RobertIndie
force-pushed
the
fix-pulsar-sql-doc
branch
from
e943010
to
8498448
Compare
shibd
approved these changes
Jul 4, 2022
momo-jun
reviewed
Jul 5, 2022
momo-jun
reviewed
Jul 5, 2022
Co-authored-by: momo-jun <[email protected]>
momo-jun
approved these changes
Jul 5, 2022
|
Thank you! Looking forward to more contributions! 😊 @RobertIndie |
wuxuanqicn
pushed a commit
to wuxuanqicn/pulsar
that referenced
this pull request
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #16354
Motivation
After #15478 gets merged, the zookeeper won't be enabled by default when starting the pulsar standalone. But the pulsar SQL depends on the zookeeper. We need to set
PULSAR_STANDALONE_USE_ZOOKEEPER=1to enable zookeeper when using the pulsar SQL as mentioned in #16354 (comment).Modifications
PULSAR_STANDALONE_USE_ZOOKEEPER=1before running pulsar standalone in pulsar-sql docThese changes only need to apply to the doc of pulsar 2.11 and later.
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)