-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pulsar-sql] Bump presto.version to run PrestoServer on JDK11+ #16163
Conversation
This is another attempt to fix apache#14951 without introduce workaround. Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
This refers to trinodb/trino@f4d7de3. Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
This change comes from #14951 (comment). And I touch this module since java-version-trim-agent is the only module uses Bump dependency version is clear and easy to maintain than introducing an in-place agent module IMO. cc @gaoran10 |
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
All tests has passed at https://github.com/apache/pulsar/runs/6997463530. The latest commit is about test file changes. So I think CPP task failed on flaky tests. |
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Great work! LGTM. But there is a similar PR, maybe we could refer to this comment #14953 (review), if we want to upgrade the Trino to |
@gaoran10 Thanks for your inputs! I'm not aware of that PR before. Let me investigate a bit and decide whether to start a thread on dev@ or close this PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
at DataStax we upgraded Presto last year, no particular issues so far
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
@eolivelli thanks for your review and information! That sounds great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@codelipenghui @eolivelli @lhotari could you give this patch a final review and merge if no further concern? |
Motivation
This is another attempt to fix #14951 without introduce workaround.
Modifications
Bump presto.version to 334.
Verifying this change
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesTo fix #14951. This version bump should be transparent to users.
Config option
presto.version
has been removed at trinodb/trino#3708. Since PrestoServer uses strict config validations, users who configurepresto.version
may get a fatal error when starting PrestoServer.Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)