-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][cpp-client] Add basic authentication #15822
Conversation
40ca481
to
795f94d
Compare
/pulsarbot rerun-failure-checks |
795f94d
to
9f556d3
Compare
9f556d3
to
58e6d1e
Compare
17a8cad
to
72689b7
Compare
@BewareMyPower Thanks for your review, your request changes has been fixed. |
Please check the failed tests introduced by this PR:
|
It looks like these tests should fail with
I'm not sure whether the anonymous role can be cancelled for a specific namespace. |
c5371c7
to
898df31
Compare
898df31
to
b38d89f
Compare
/pulsarbot rerun-failure-checks |
Signed-off-by: Zixuan Liu <[email protected]>
Signed-off-by: Zixuan Liu <[email protected]>
b38d89f
to
4addb12
Compare
* [improve][cpp-client] Add basic authentication Signed-off-by: Zixuan Liu <[email protected]> * Fix test Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 4840a98)
It's a new feature, we should not cherry-pick it to release branches. |
Brokers have long supported basic authentication, but clients have not, so I think we should cherry-pick. |
Maybe you need to open a discussion in mail list. BTW, @merlimat what's your opinion about cherry-picking new features of C++ client into release branches? |
@BewareMyPower I have a question to ask if the c++-client will only have one latest version, this is different from Java-Client, which comes in multiple versions. |
No. The version management is the same with Java client. |
* [improve][cpp-client] Add basic authentication Signed-off-by: Zixuan Liu <[email protected]> * Fix test Signed-off-by: Zixuan Liu <[email protected]>
Signed-off-by: Zixuan Liu [email protected]
Motivation
The basic authentication is missed in cpp-client.
Modifications
Documentation
doc-required
Add authentication code snippet of cpp-client to the Basic Authentication page.
doc-complete
- [improve][doc] Add more configuration methods for basic authentication #16941