[Improve][txn] extend admin tools for transaction component. #15675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation In order to better monitor the usage of transactions. And more convenient positioning problem, so we hope to get more information when getting TB, TP, TC status. ### Modification 1. Add lowWaterMarks (optional) in stats of TB, TP. 2. Add brokerOwnerUrl in stats of TB, TP 3. Add ongoingtxns in stast of TB, TP, TC.
Technoboy-
reviewed
May 19, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java
Outdated
Show resolved
Hide resolved
liangyepianzhou
changed the title
eolivelli
requested changes
May 25, 2022
...r/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java
Outdated
Show resolved
Hide resolved
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Transactions.java
Show resolved
Hide resolved
congbobo184
reviewed
Jun 2, 2022
...t-admin-api/src/main/java/org/apache/pulsar/common/policies/data/TransactionBufferStats.java
Outdated
Show resolved
Hide resolved
...in-api/src/main/java/org/apache/pulsar/common/policies/data/TransactionCoordinatorStats.java
Outdated
Show resolved
Hide resolved
...min-api/src/main/java/org/apache/pulsar/common/policies/data/TransactionPendingAckStats.java
Outdated
Show resolved
Hide resolved
congbobo184
approved these changes
Jun 20, 2022
...t-admin-api/src/main/java/org/apache/pulsar/common/policies/data/TransactionBufferStats.java
Outdated
Show resolved
Hide resolved
...min-api/src/main/java/org/apache/pulsar/common/policies/data/TransactionPendingAckStats.java
Outdated
Show resolved
Hide resolved
eolivelli
reviewed
Jun 21, 2022
...src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java
Show resolved
Hide resolved
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to better monitor the usage of transactions. And more convenient positioning problem, so we hope to get more information when getting TB, TP, TC status.
Modification
About lowWaterMark in TP
Fake code, wait the #15592 merge
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
no-need-doc(Please explain why)
doc(Your PR contains doc changes)
doc-added(Docs have been already added)