Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIP-158][improve][client] Split client TLS transport encryption from authentication #15634

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

nodece
Copy link
Member

@nodece nodece commented May 17, 2022

Fixes #15289

Motivation

The client supports TLS transport encryption and TLS authentication, this code so like:

PulsarClient client = PulsarClient.builder()
                .serviceUrl("pulsar+ssl://localhost:6651")
                .tlsTrustCertsFilePath("/path/to/cacert.pem")
                .authentication(AuthenticationTls.class.getName(), authParams)
                .build()

We are using AuthenticationTls to perform the TLS transport encryption and TLS authentication, this causes an issue that cannot use other authentication with TLS transport encryption, and also made our confusion if we use TLS transport encryption by setting authentication.

Documentation

Check the box below or label this PR directly.

Need to update docs?

@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label May 17, 2022
@nodece nodece force-pushed the split-tls-transport branch from 18087cf to 38c81ae Compare May 17, 2022 15:40
@nodece nodece force-pushed the split-tls-transport branch from 38c81ae to 41fb6d6 Compare June 6, 2022 03:09
@nodece nodece force-pushed the split-tls-transport branch 2 times, most recently from adfba55 to 4d786fb Compare June 28, 2022 03:19
Copy link
Contributor

@BewareMyPower BewareMyPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done my review for all code changes and left two request changes, PTAL.

@nodece nodece force-pushed the split-tls-transport branch from 4d786fb to 7241c8a Compare June 29, 2022 15:53
@nodece nodece force-pushed the split-tls-transport branch from 7241c8a to a9b949c Compare June 30, 2022 02:11
@nodece nodece added component/client-java type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages labels Jun 30, 2022
@nodece nodece force-pushed the split-tls-transport branch from a9b949c to faf62de Compare July 12, 2022 14:28
@Technoboy- Technoboy- added this to the 2.11.0 milestone Jul 26, 2022
Copy link
Contributor

@Technoboy- Technoboy- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codelipenghui codelipenghui added the release/important-notice The changes which are important should be mentioned in the release note label Jul 26, 2022
@codelipenghui codelipenghui merged commit 6f1f6aa into apache:master Jul 26, 2022
@Anonymitaet Anonymitaet added doc-complete Your PR changes impact docs and the related docs have been already added. and removed doc-required Your PR changes impact docs and you will update later. labels Aug 4, 2022
Gleiphir2769 pushed a commit to Gleiphir2769/pulsar that referenced this pull request Aug 4, 2022
@nodece nodece mentioned this pull request Feb 10, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-complete Your PR changes impact docs and the related docs have been already added. release/important-notice The changes which are important should be mentioned in the release note type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PIP-158: Split client TLS transport encryption from authentication
5 participants