-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PIP-158][improve][client] Split client TLS transport encryption from authentication #15634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
Your PR changes impact docs and you will update later.
label
May 17, 2022
nodece
force-pushed
the
split-tls-transport
branch
from
May 17, 2022 15:40
18087cf
to
38c81ae
Compare
2 tasks
nodece
force-pushed
the
split-tls-transport
branch
from
June 6, 2022 03:09
38c81ae
to
41fb6d6
Compare
nodece
force-pushed
the
split-tls-transport
branch
2 times, most recently
from
June 28, 2022 03:19
adfba55
to
4d786fb
Compare
BewareMyPower
requested changes
Jun 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done my review for all code changes and left two request changes, PTAL.
pulsar-common/src/main/java/org/apache/pulsar/common/util/NettyClientSslContextRefresher.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/apache/pulsar/client/impl/KeyStoreTlsProducerConsumerTestWithAuthTest.java
Outdated
Show resolved
Hide resolved
nodece
force-pushed
the
split-tls-transport
branch
from
June 29, 2022 15:53
4d786fb
to
7241c8a
Compare
nodece
force-pushed
the
split-tls-transport
branch
from
June 30, 2022 02:11
7241c8a
to
a9b949c
Compare
nodece
added
component/client-java
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
labels
Jun 30, 2022
BewareMyPower
approved these changes
Jul 1, 2022
… authentication Signed-off-by: Zixuan Liu <[email protected]>
nodece
force-pushed
the
split-tls-transport
branch
from
July 12, 2022 14:28
a9b949c
to
faf62de
Compare
Technoboy-
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
codelipenghui
added
the
release/important-notice
The changes which are important should be mentioned in the release note
label
Jul 26, 2022
codelipenghui
approved these changes
Jul 26, 2022
This was referenced Jul 27, 2022
Anonymitaet
added
doc-complete
Your PR changes impact docs and the related docs have been already added.
and removed
doc-required
Your PR changes impact docs and you will update later.
labels
Aug 4, 2022
Gleiphir2769
pushed a commit
to Gleiphir2769/pulsar
that referenced
this pull request
Aug 4, 2022
This was referenced Aug 12, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc-complete
Your PR changes impact docs and the related docs have been already added.
release/important-notice
The changes which are important should be mentioned in the release note
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15289
Motivation
The client supports TLS transport encryption and TLS authentication, this code so like:
We are using AuthenticationTls to perform the TLS transport encryption and TLS authentication, this causes an issue that cannot use other authentication with TLS transport encryption, and also made our confusion if we use TLS transport encryption by setting
authentication
.Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required
(Your PR needs to update docs and you will update later)
doc-complete
- [improve][doc] Improve TLS transport encryption and authentication #16924