[cleanup] [broker] Remove useless code to avoid confusion in OpReadEntry#checkReadCompletion #15104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@horizonzy:Thanks for your contribution. For this PR, do we need to update docs? |
|
@horizonzy:Thanks for providing doc info! |
1 task
|
LGTM |
HQebupt
approved these changes
Apr 11, 2022
mattisonchao
approved these changes
Apr 11, 2022
codelipenghui
approved these changes
Apr 11, 2022
aparajita89
pushed a commit
to aparajita89/pulsar
that referenced
this pull request
Apr 18, 2022
…try#checkReadCompletion. (apache#15104)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…try#checkReadCompletion. (apache#15104)
|
This PR need to cherry-pick to another branch, because when invoke @codelipenghui @horizonzy Could you help to confirm it? |
|
Sure
发自我的iPhone
…------------------ Original ------------------
From: Qiang Zhao ***@***.***>
Date: Sat,May 28,2022 8:46 AM
To: apache/pulsar ***@***.***>
Cc: Yan Zhao ***@***.***>, Mention ***@***.***>
Subject: Re: [apache/pulsar] [cleanup] [broker] Remove useless code to avoidconfusion in OpReadEntry#checkReadCompletion (PR #15104)
This PR need to cherry-pick to another branch, because when invoke cursor.ledger.startReadOperationOnLedger(nextReadPosition, OpReadEntry.this); twice may cause NPE when ledger id equals null and then failed this OpAddEntry and recycle it.
@codelipenghui @horizonzy Could you help to confirm it?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
codelipenghui
pushed a commit
to codelipenghui/incubator-pulsar
that referenced
this pull request
Jun 7, 2022
…try#checkReadCompletion. (apache#15104) (cherry picked from commit 9376128)
codelipenghui
added
release/2.10.2
cherry-picked/branch-2.10
and removed
release/2.10.1
release/2.10.2
labels
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 7, 2022
…try#checkReadCompletion. (apache#15104) (cherry picked from commit 9376128) (cherry picked from commit f03b168)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15103
Motivation
Remove useless code.
no-need-doc(Please explain why)
doc-not-needed