Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pulsar-functions dist package into pulsar binary distribution #1332

Merged
merged 24 commits into from
Mar 6, 2018

Conversation

sijie
Copy link
Member

@sijie sijie commented Mar 5, 2018

This change is based on #1331

6ccd903 is the change for review in this PR.

@sijie sijie self-assigned this Mar 5, 2018
@sijie sijie requested review from merlimat and rdhabalia March 5, 2018 09:27
- rename `pulsar-client-tools-shaded` to `pulsar-client-admin-shaded-for-functions`, because this module is used by functions only to avoid protobuf conflicts
- move protobuf3 references to Utils, so it won't be referenced out side of pulsar-functions
- integrate function cli into pulsar-admin cli
@sijie
Copy link
Member Author

sijie commented Mar 6, 2018

retest this please

@srkukarni
Copy link
Contributor

retest this please

@srkukarni
Copy link
Contributor

retest this please

Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat merlimat merged commit e9e31c7 into apache:master Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants