Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use duplicates when writing from ByteBuf pair to avoid multiple threads issues #1203

Merged
merged 1 commit into from
Feb 8, 2018
Merged

Use duplicates when writing from ByteBuf pair to avoid multiple threads issues #1203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pulsar-common/src/main/java/org/apache/pulsar/common/api/ByteBufPair.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,8 @@ public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise promise)
// ByteBuf are automatically released after a write. If the ByteBufPair ref count is increased and it
// gets written multiple times, the individual buffers refcount should be reflected as well.
try {
ctx.write(b.getFirst().retain(), ctx.voidPromise());
ctx.write(b.getSecond().retain(), promise);
ctx.write(b.getFirst().retainedDuplicate(), ctx.voidPromise());
ctx.write(b.getSecond().retainedDuplicate(), promise);
} finally {
ReferenceCountUtil.safeRelease(b);
}
Expand Down