Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Hide FailFastSkipExceptions and mark the test as skipped #10251

Merged
merged 1 commit into from
Apr 18, 2021

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Apr 17, 2021

Motivation

Hiding FailFastSkipExceptions makes it easier to find the actual test failure in the log output when the test fails.
Fail fast testing mode was introduced in #10195 .

Modifications

  • remove the exception and set the status of the test result to skip in the TestNG listener

- this makes it easier to find the actual test failure in the log output
@lhotari lhotari changed the title [TestsHide FailFastSkipExceptions and mark the test as skipped [Tests] Hide FailFastSkipExceptions and mark the test as skipped Apr 17, 2021
@lhotari
Copy link
Member Author

lhotari commented Apr 17, 2021

@aahmed-se @eolivelli Please review

@eolivelli
Copy link
Contributor

Cool

@merlimat merlimat added this to the 2.8.0 milestone Apr 18, 2021
@merlimat merlimat merged commit ce42e5b into apache:master Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants