address comments

apache · Nov 18, 2022 · 9295d45 · 9295d45
1 parent d41427d
commit 9295d45
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ShadowManagedLedgerImpl.java b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ShadowManagedLedgerImpl.java
@@ -93,13 +93,10 @@ public void operationComplete(MLDataFormats.ManagedLedgerInfo mlInfo, Stat stat)
                     log.debug("[{}][{}] Source ML info:{}", name, sourceMLName, mlInfo);
                 }
                 sourceLedgersStat = stat;
-                // Fails if init with empty ledger. Very small chance here, since shadow topic is
-                // created when source topic exists.
                 if (mlInfo.getLedgerInfoCount() == 0) {
+                    // Small chance here, since shadow topic is created after source topic exists.
                     log.warn("[{}] Source topic ledger list is empty! source={},mlInfo={},stat={}", name, sourceMLName,
                             mlInfo, stat);
-//                    callback.initializeFailed(new ManagedLedgerException.ManagedLedgerSourceNotReadyException(
-//                            "Source managed ledger " + sourceMLName + " is not ready yet."));
                     ShadowManagedLedgerImpl.super.initialize(callback, ctx);
                     return;
                 }
@@ -281,7 +278,8 @@ protected synchronized void internalAsyncAddEntry(OpAddEntry addOperation) {
     private synchronized void processSourceManagedLedgerInfo(MLDataFormats.ManagedLedgerInfo mlInfo, Stat stat) {
 
         if (log.isDebugEnabled()) {
-            log.debug("[{}][{}] new SourceManagedLedgerInfo:{}", name, sourceMLName, mlInfo);
+            log.debug("[{}][{}] new SourceManagedLedgerInfo:{}, prevStat={},stat={}", name, sourceMLName, mlInfo,
+                    sourceLedgersStat, stat);
         }
 
         sourceLedgersStat = stat;

diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Producer.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Producer.java
@@ -348,6 +348,9 @@ public TransportCnx getCnx() {
         return this.cnx;
     }
 
+    /**
+     * MessagePublishContext implements Position because that ShadowManagedLedger need to know the source position info.
+     */
     private static final class MessagePublishContext implements PublishContext, Runnable, Position {
         /*
          * To store context information built by message payload