resolved minor comments

apache · Feb 22, 2023 · 77209e7 · 77209e7
1 parent 2fbafc9
commit 77209e7
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/...c/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitState.java b/...c/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitState.java
@@ -24,7 +24,7 @@
 /**
  * Defines the possible states for service units.
  *
- * Refer to Service Unit State Channel in https://github.com/apache/pulsar/issues/16691 for additional details.
+ * @see <a href="https://github.com/apache/pulsar/issues/16691"> Service Unit State Channel </a> for additional details.
  */
 public enum ServiceUnitState {
 

diff --git a/.../org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java b/.../org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java
@@ -959,7 +959,7 @@ private void doCleanup(String broker) throws ExecutionException, InterruptedExce
         log.info("Started ownership cleanup for the inactive broker:{}", broker);
         int orphanServiceUnitCleanupCnt = 0;
         long totalCleanupErrorCntStart = totalCleanupErrorCnt.get();
-        var availableBrokers = new HashSet(brokerRegistry.getAvailableBrokersAsync()
+        var availableBrokers = new HashSet<>(brokerRegistry.getAvailableBrokersAsync()
                 .get(inFlightStateWaitingTimeInMillis, MILLISECONDS));
         for (var etr : tableview.entrySet()) {
             var stateData = etr.getValue();

diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/compaction/ServiceUnitStateCompactionTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/compaction/ServiceUnitStateCompactionTest.java
@@ -536,7 +536,6 @@ public void testSlowTableviewAfterCompaction() throws Exception {
                     // Stuck at handling Assigned
                     handledReleased.set(false);
                     semaphore.acquire();
-                    //Thread.sleep(5000);
                 } catch (InterruptedException e) {
                     throw new RuntimeException(e);
                 }