Add comment

apache · Mar 23, 2023 · 133887f · 133887f
1 parent f854c59
commit 133887f
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/...r/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java b/...r/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java
@@ -339,20 +339,22 @@ public synchronized boolean addMessage(long ledgerId, long entryId, long deliver
     private synchronized CompletableFuture<Void> asyncMergeBucketSnapshot() {
         List<ImmutableBucket> values = immutableBuckets.asMapOfRanges().values().stream().toList();
         long minNumberMessages = Long.MAX_VALUE;
-        long minScheduleTimestampSum = Long.MAX_VALUE;
+        long minScheduleTimestamp = Long.MAX_VALUE;
         int minIndex = -1;
         for (int i = 0; i + 1 < values.size(); i++) {
             ImmutableBucket bucketL = values.get(i);
             ImmutableBucket bucketR = values.get(i + 1);
+            // We should skip the bucket which last segment already been load to memory, avoid record replicated index.
             if (bucketL.lastSegmentEntryId > bucketL.getCurrentSegmentEntryId()
                     && bucketR.lastSegmentEntryId > bucketR.getCurrentSegmentEntryId()
+                    // Skip the bucket that is merging
                     && !bucketL.merging && !bucketR.merging){
-                long scheduleTimestampSum =
+                long scheduleTimestamp =
                         Math.min(bucketL.firstScheduleTimestamps.get(bucketL.currentSegmentEntryId + 1),
                                 bucketR.firstScheduleTimestamps.get(bucketR.currentSegmentEntryId + 1));
                 long numberMessages = bucketL.numberBucketDelayedMessages + bucketR.numberBucketDelayedMessages;
-                if (scheduleTimestampSum <= minScheduleTimestampSum) {
-                    minScheduleTimestampSum = scheduleTimestampSum;
+                if (scheduleTimestamp <= minScheduleTimestamp) {
+                    minScheduleTimestamp = scheduleTimestamp;
                     if (numberMessages < minNumberMessages) {
                         minNumberMessages = numberMessages;
                         minIndex = i;