Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client-libraries-cluster-level-failover.md #969

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

visxu
Copy link
Contributor

@visxu visxu commented Oct 28, 2024

Fix issue: apache/pulsar#23512

✅ Contribution Checklist

@visxu
Copy link
Contributor Author

visxu commented Oct 28, 2024

@nodece Please help review the PR, thanks.

@nodece nodece merged commit 364ec17 into apache:main Oct 28, 2024
2 checks passed
@nodece
Copy link
Member

nodece commented Oct 28, 2024

@visxu Good work!

@lhotari
Copy link
Member

lhotari commented Oct 30, 2024

@nodece When documentation changes apply to existing supported versions, the versioned documentation in the versioned_docs directory should also be updated with the change. That was missed in this PR.
In the future, we could make it easier by providing a script in the pulsar-site repository that applies the changes made to docs folder to the versioned_docs of the supported versions. I have some personal scripts for handling this, but something similar could be part of pulsar-site repository and our instructions.

@nodece
Copy link
Member

nodece commented Oct 31, 2024

#968 is applied to the 3.0.x. If we can provide a script to cherry-pick this RP to the existing supported versions, it is awesome.

@lhotari
Copy link
Member

lhotari commented Oct 31, 2024

#968 is applied to the 3.0.x. If we can provide a script to cherry-pick this RP to the existing supported versions, it is awesome.

@nodece I have added the script in #972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants