Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.10.2 Release Note #262

Merged
merged 16 commits into from
Oct 27, 2022
Merged

Conversation

Jason918
Copy link
Contributor

No description provided.

Copy link
Member

@Anonymitaet Anonymitaet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As explained in https://github.com/apache/pulsar/blob/master/wiki/release/release-note-guide.md#submit-release-notes:

  1. CPP release notes are generated from its repo https://github.com/apache/pulsar-client-cpp, may I know so why submit CPP release note here?

  2. May I know why the WebSocket release note is not in this PR? No updates for it?

Copy link
Member

@Anonymitaet Anonymitaet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaveDuggins @D-2-Ed do you have more review comments from the TW perspective?

@Jason918
Copy link
Contributor Author

@Anonymitaet

  1. CPP release notes are generated from its repo https://github.com/apache/pulsar-client-cpp, may I know so why submit CPP release note here?

The separate cpp release starts from 2.11.x, for existing branches, we need to keep the compatibility.

See "Existing branches" part in apache/pulsar#17724

2. May I know why the WebSocket release note is not in this PR? No updates for it?

Yes, I don't see any updates on WebSocket client.

@Anonymitaet
Copy link
Member

Anonymitaet commented Oct 24, 2022

@Anonymitaet

  1. CPP release notes are generated from its repo https://github.com/apache/pulsar-client-cpp, may I know so why submit CPP release note here?

The separate cpp release starts from 2.11.x, for existing branches, we need to keep the compatibility.

See "Existing branches" part in apache/pulsar#17724

@SignorMercurio FYI, please take care of the special release note process for CPP ⬆️

Copy link
Contributor

@momo-jun momo-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jason918
Copy link
Contributor Author

@Anonymitaet PTAL

@michaeljmarshall michaeljmarshall merged commit 8370c93 into apache:main Oct 27, 2022
@Jason918 Jason918 deleted the release-note-2.10.2 branch October 28, 2022 01:46
@Jason918
Copy link
Contributor Author

@Anonymitaet @momo-jun
After this PR is merged, do I need to do anything else for this new release information to show on the Pulsar Release Note page?

According to https://github.com/apache/pulsar/blob/master/wiki/release/release-note-guide.md, it should be done automatically. But it seems not working.

@Anonymitaet
Copy link
Member

Hi @SignorMercurio can you please check this? ⬆️ Thanks

2.10.2 release notes for Pulsar, Java, and CPP are available at https://github.com/apache/pulsar-site/tree/main/site2/website-next/release-notes/versioned but they are not shown on https://pulsar.apache.org/release-notes/

@Jason918
Copy link
Contributor Author

Can you help confirm that we need to update site2/website/releases.json in pulsar main repo? like apache/pulsar#17670
@Anonymitaet @momo-jun @SignorMercurio

@Jason918
Copy link
Contributor Author

Can you help confirm that we need to update site2/website/releases.json in pulsar main repo? like apache/pulsar#17670
@Anonymitaet @momo-jun @SignorMercurio

I opened a PR here:apache/pulsar#18262 PTAL

@SignorMercurio
Copy link
Contributor

SignorMercurio commented Oct 31, 2022

Hi @Anonymitaet @Jason918, the issue that 2.10.2 release is not shown on the page is caused by a simple mistake that I'll fix with a PR soon. There's no need to modify any json file.

I see that apache/pulsar#18262 is merged. Actually it won't fix the issue (Perhaps releases.json is not even used now) but it won't bring any harm either, so there's no need to revert it.

@Jason918
Copy link
Contributor Author

Hi @Anonymitaet @Jason918, the issue that 2.10.2 release is not shown on the page is caused by a simple mistake that I'll fix with a PR soon. There's no need to modify any json file.

@SignorMercurio Great, please let me know when it's fixed. It's blocking the announcement of release 2.10.2

@SignorMercurio
Copy link
Contributor

@Jason918 It's fixed now, please check out https://pulsar.apache.org/release-notes/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants