[flaky tests] Fix flaky ShutdownTest::testDestructor #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes apache#61 ### Motivation `testDestructor` is flaky because the destructor might not be called immediately after the `shared_ptr` object goes out of the scope. It's similar like the flaky `testReferenceCount` before in apache/pulsar#17645. ### Modifications Add back `WaitUtils.h`, which was removed in apache#55, add use `waitUntil` to wait until the assertion. ### Verifications Run the reproduce script in apache#61. Even if the loop count was increased to 100, it still never failed.
merlimat
approved these changes
Oct 21, 2022
BewareMyPower
added a commit
that referenced
this pull request
Nov 1, 2022
Fixes #61 ### Motivation `testDestructor` is flaky because the destructor might not be called immediately after the `shared_ptr` object goes out of the scope. It's similar like the flaky `testReferenceCount` before in apache/pulsar#17645. ### Modifications Add back `WaitUtils.h`, which was removed in #55, add use `waitUntil` to wait until the assertion. ### Verifications Run the reproduce script in #61. Even if the loop count was increased to 100, it still never failed. (cherry picked from commit 7bb6402)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61
Motivation
testDestructoris flaky because the destructor might not be called immediately after theshared_ptrobject goes out of the scope. It's similar like the flakytestReferenceCountbefore in apache/pulsar#17645.Modifications
Add back
WaitUtils.h, which was removed in #55, add usewaitUntilto wait until the assertion.Verifications
Run the reproduce script in #61. Even if the loop count was increased to 100, it still never failed.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)