Fix segmenatation fault if connection is closed during handshake #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait for #400 to be merged |
Fixes apache#398 ### Motivation There is an implicit requirement for the `async_handshake` API that before it's done, the `socket` and `ssl::stream` objects must exist. Otherwise segmenatation fault might happen. ### Modifications Capture `socket_` and `tlsSocket_` in the handshake callback. It can be verified by modifying the code according to apache#398 and rerun the test.
BewareMyPower
force-pushed
the
bewaremypower/fix-handshake
branch
from
17cc4c3 to
0550445
Compare
merlimat
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #398
Motivation
There is an implicit requirement for the
async_handshakeAPI that before it's done, thesocketandssl::streamobjects must exist. Otherwise segmenatation fault might happen.Modifications
Capture
socket_andtlsSocket_in the handshake callback. It can be verified by modifying the code according to #398 and rerun the test.