Fix the operation timeout is not honored for GetSchema requests #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are other requests that don't honor the operation timeout as well. In future, we might refactor the logic to send any request with a timeout like: sendRequest(request, timeout).thenApply(response -> handleXxx(response.getXxxResponse()); |
|
The main branch is broken. I pushed a PR to fix: #384 |
BewareMyPower
force-pushed
the
bewaremypower/get-schema-timeout
branch
2 times, most recently
from
616a120 to
8858744
Compare
merlimat
reviewed
Jan 18, 2024
lib/RetryableOperationCache.h
Outdated
| @@ -40,8 +41,8 @@ class RetryableOperationCache : public std::enable_shared_from_this<RetryableOpe | |||
| explicit PassKey() {} | |||
| }; | |||
|
|
|||
| RetryableOperationCache(ExecutorServiceProviderPtr executorProvider, int timeoutSeconds) | |||
| : executorProvider_(executorProvider), timeoutSeconds_(timeoutSeconds) {} | |||
| RetryableOperationCache(ExecutorServiceProviderPtr executorProvider, std::chrono::nanoseconds timeoutMs) | |||
There was a problem hiding this comment.
is this nanoseconds or milliseconds?
There was a problem hiding this comment.
Oh the name is wrong. It should be nanoseconds. I will address it
There was a problem hiding this comment.
I removed all Ms or Seconds prefixes and use TimeDuration as the type now, PTAL again.
Fixes apache#357 ### Motivation In `Client::getSchemaInfoAsync`, the underlying `LookupService::getSchema` is called, which does not register a timer according to the operation timeout. ### Modifications Register a timer and cache it and the GetSchema promise in `ClientConnection::pendingGetSchemaRequests_`, then remove the entry and complete the promise with `ResultTimeout`. To verify the timeout is honored, modify the timeout type from `int` to `chrono::nanoseconds` so that a smaller timeout can be configured. Then test a small enough timeout (1 ns) in `LookupServiceTest.testGetSchemaTimeout`.
BewareMyPower
force-pushed
the
bewaremypower/get-schema-timeout
branch
from
8858744 to
25bd34b
Compare
merlimat
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #357
Motivation
In
Client::getSchemaInfoAsync, the underlyingLookupService::getSchemais called, which does not register a timer according to the operation timeout.Modifications
Register a timer and cache it and the GetSchema promise in
ClientConnection::pendingGetSchemaRequests_, then remove the entry and complete the promise withResultTimeout.To verify the timeout is honored, modify the timeout type from
inttochrono::nanosecondsso that a smaller timeout can be configured. Then test a small enough timeout (1 ns) inLookupServiceTest.testGetSchemaTimeout.