Avoid copying OpSendMsg when sending messages #308
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306
Motivation
OpSendMsg
is a struct whose size is 400 bytes. We should avoid the copy operation on it.Modifications
Pass the
unique_ptr<OpSendMsg>
everywhere instead ofOpSendMsg
.unique_ptr<OpSendMsg>
as the element of the pending message queue inProducerImpl
and disable the copy constructor and assignment forOpSendMsg
.SendArgument
, which includes the necessary fields to construct aCommandSend
request. Useshared_ptr
rather thanunique_ptr
to storeSendArgument
inOpSendMsg
because the producer might need to resend the message so theSendArgument
object could be shared byProducerImpl
andClientConnection
.This patch is more like a refactor because it is not a key factor that affects the throughput or latency.
Documentation
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)