Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci failed on macos env. #288

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Fix ci failed on macos env. #288

merged 1 commit into from
Jun 21, 2023

Conversation

shibd
Copy link
Member

@shibd shibd commented Jun 20, 2023

Motivation

https://github.com/apache/pulsar-client-cpp/actions/runs/5321241967/jobs/9636098738?pr=287

The root cause is the protobuf release v23.3 last week, which requires the abseil library that is built with C++ 17.

https://github.com/Homebrew/homebrew-core/blob/1a476ad7dc979671b4faf7601ae7d0cb6f39d9cf/Formula/protobuf.rb#L45-L46

Modifications

  • Specify to install protobuf v21.12

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@shibd shibd requested a review from BewareMyPower June 20, 2023 15:25
@shibd shibd self-assigned this Jun 20, 2023
@shibd shibd added this to the 3.3.0 milestone Jun 20, 2023
@BewareMyPower BewareMyPower merged commit 7cfe07c into apache:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants