Fix testSchemaIncompatibility for Protobuf 3.20.0 or later #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes apache#193 ### Motivation `getExternalMessageDescriptor` returns the descriptor of `TestMessage` rather than `ExternalMessage` for Protobuf 3.20.0 or later. And the conditional compilation is meaningless here because `GetDescriptor` is always a static method while it didn't exist for some early versions of Protobuf. The official documentation suggests using `descriptor()`. ### Modifications Use `descriptor()` method to get the descriptor of a PB class.
BewareMyPower
requested review from
merlimat,
RobertIndie,
tisonkun,
shibd and
mattisonchao
shibd
approved these changes
Jun 13, 2023
tisonkun
approved these changes
Jun 13, 2023
|
CI seems failed on vcpkg downloads issue 😨 |
|
@tisonkun Yes, the Vcpkg downloading was very unstable recently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #193
Motivation
getExternalMessageDescriptorreturns the descriptor ofTestMessagerather thanExternalMessagefor Protobuf 3.20.0 or later. And the conditional compilation is meaningless here becauseGetDescriptoris always a static method while it didn't exist for some early versions of Protobuf. The official documentation suggests usingdescriptor().Modifications
Use
descriptor()method to get the descriptor of a PB class.Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)