Fix flaky testConsumerEventWithoutPartition cause by the change of Pulsar 3.0 #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lsar 3.0 ### Motivation apache/pulsar#19502 brings a change to the consumer selection of the Failover subscription. Before that PR, if a new consumer joins a Failover subscription when there is a consumer that subscribes the topic, the new consumer will receive the "inactive" event. After that PR, a random consumer will receive the "inactive" event. ### Modifications Change the assertion when `consumer` subscribes the topic with the same subscription. In addition, use a thread safe queue to avoid race conditions.
BewareMyPower
requested review from
merlimat,
RobertIndie,
Demogorgon314 and
shibd
hezhangjian
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #280
Motivation
apache/pulsar#19502 brings a change to the consumer selection of the Failover subscription.
Before that PR, if a new consumer joins a Failover subscription when there is a consumer that subscribes the topic, the new consumer will receive the "inactive" event.
After that PR, a random consumer will receive the "inactive" event.
Modifications
Change the assertion when
consumersubscribes the topic with the same subscription.In addition, use a thread safe queue to avoid race conditions.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)