-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][consumer] Support parse broker metadata #276
Conversation
I'm experiencing some difficulties when running
|
5e055a5
to
c700dbd
Compare
e6a57ee
to
fcebc61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR seems more like a fix. Overall looks good to me.
Could you add some tests to verify it?
@RobertIndie Would it be possible for you to provide me with some examples? I am not familiar with cpp and this repo. I would really appreciate your guidance. |
I think we can easily test this feature by configuring A better way is to add a test with a custom config like #249. We can add a separated test with a separated Pulsar standalone service. |
fcebc61
to
3f93121
Compare
3f93121
to
ded7b69
Compare
4969de7
to
3808591
Compare
3808591
to
a1f5cd0
Compare
### Motivation After #276 , We already can consume messages contains index well. Now we can add a method allow user to getIndex. Index is an optional brokerMetadata. If the index not exists, we will return -1 ### Verifying this change - Add the assertions to assert the index not equals -1.
Motivation
pulsar-client-cpp doesn't support parse broker metadata. Which will error whiling connect to enabledbrokerMetada pulsar.
This PR makes pulsar-client-cpp can consume messages well, but haven't exposing index interface yet.
See also
apache/pulsar-client-go#745
https://github.com/apache/pulsar/blob/e38091044c428af002b16110531497e2abc897d2/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L1289
Documentation
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)