-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Support end-to-end encryption in C Reader API #262
Conversation
Nice work! Can you fix the code format and add a unit test? |
@shibd Thank you for the feedback! I've fixed the formatting and wrote a very basic test for the reader config C API, much like the one for the consumer configuration. If this PR gets approved, is there any chance to still get this into the 3.2.0 release (saw the voting thread on the dev mailing list)? This would be really great since my ultimate goal is address apache/pulsar-client-node#276 |
/cc @BewareMyPower I think we should include it on the 3.2.0 release. |
(cherry picked from commit 043c88b)
Fixes #166 and is a prerequisite for apache/pulsar-client-node#276
Motivation
This change allows C and derived clients to use end-to-end encryption for Readers.
Modifications
Exposed the methods that already in the C++ API in the C interface
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)