Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Support end-to-end encryption in C Reader API #262

Merged
merged 5 commits into from
May 5, 2023

Conversation

rbarbey
Copy link
Contributor

@rbarbey rbarbey commented May 2, 2023

Fixes #166 and is a prerequisite for apache/pulsar-client-node#276

Motivation

This change allows C and derived clients to use end-to-end encryption for Readers.

Modifications

Exposed the methods that already in the C++ API in the C interface

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@shibd
Copy link
Member

shibd commented May 4, 2023

Nice work! Can you fix the code format and add a unit test?

@rbarbey
Copy link
Contributor Author

rbarbey commented May 4, 2023

@shibd Thank you for the feedback! I've fixed the formatting and wrote a very basic test for the reader config C API, much like the one for the consumer configuration.

If this PR gets approved, is there any chance to still get this into the 3.2.0 release (saw the voting thread on the dev mailing list)? This would be really great since my ultimate goal is address apache/pulsar-client-node#276

@shibd
Copy link
Member

shibd commented May 4, 2023

@shibd Thank you for the feedback! I've fixed the formatting and wrote a very basic test for the reader config C API, much like the one for the consumer configuration.

If this PR gets approved, is there any chance to still get this into the 3.2.0 release (saw the voting thread on the dev mailing list)? This would be really great since my ultimate goal is address apache/pulsar-client-node#276

/cc @BewareMyPower I think we should include it on the 3.2.0 release.

@BewareMyPower BewareMyPower added the enhancement New feature or request label May 5, 2023
@BewareMyPower BewareMyPower added this to the 3.2.0 milestone May 5, 2023
@BewareMyPower BewareMyPower merged commit 043c88b into apache:main May 5, 2023
BewareMyPower pushed a commit that referenced this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] C Reader api support End-to-end Encryption
3 participants