Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Support ExclusiveWithFencing producer access mode. #201

Merged
merged 3 commits into from
Mar 21, 2023

Conversation

shibd
Copy link
Member

@shibd shibd commented Feb 20, 2023

Motivation

#95

Modifications

  • Support ExclusiveWithFencing producer access mode.

Verifying this change

  • Add testExclusiveWithFencingProducer to cover it.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@shibd shibd self-assigned this Feb 20, 2023
@shibd shibd added the enhancement New feature or request label Feb 20, 2023
@shibd shibd added this to the 3.2.0 milestone Feb 20, 2023
@shibd shibd requested a review from RobertIndie March 20, 2023 03:52
@shibd shibd closed this Mar 20, 2023
@shibd shibd reopened this Mar 20, 2023
@shibd shibd requested a review from RobertIndie March 20, 2023 15:15
@shibd shibd merged commit 3ae6d1f into apache:main Mar 21, 2023
@Anonymitaet
Copy link
Member

Anonymitaet commented Apr 18, 2023

Hi @shibd, thanks for introducing this great feature!

========================================

As we discussed just now, for the doc side:

✅ Pulsar feature matrix

I've ticked the 4 boxes of "Access Mode" for C++.

✅ Pulsar client docs

🌈 Collobration way

To add docs for it, feel free to choose your preferred method (either way works for me):

  • You provide tech inputs to me. I'll write docs based on them and request your review. Or

  • You submit a PR to the pulsar-site repo directly and request my review.

🌈 TO-DO tasks

  1. Create a topic named "Enable access mode" in work with producers. It should explain:
  • What is it? (we already have this conceptual content, just add the link to this topic)
  • How to use it? (e.g., any considerations? Sample code, etc.)

image

  1. This doc is added to 5 doc versions (NEXT, 2.11.x, 2.10.x, 2.9.x, 2.8.x) since this feature is available from Pulsar 2.8.x.
  • Original doc file of NEXT is here.
  • Original doc files of all versioned docs are here.

We can update one version first and apply the same doc changes to the rest once it gets approved.

========================================

Feel free to reach out to me if you have questions. TIA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants