Fix broken main branch that failed to build the wireshark dissector on macOS #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n macOS ### Motivation https://github.com/apache/pulsar-client-cpp/actions/runs/4220713571/jobs/7327254536 It failed because `pkg-config` is not installed by default after the upgrade of `macos-12` GitHub runner image. ### Modifications Install the `pkg-config` dependency.
5 tasks
Demogorgon314
approved these changes
Feb 20, 2023
shibd
approved these changes
Feb 20, 2023
RobertIndie
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://github.com/apache/pulsar-client-cpp/actions/runs/4220713571/jobs/7327254536
It failed because
pkg-configis not installed by default after the upgrade ofmacos-12GitHub runner image.Here is a fix from the upstream: actions/runner-images#7125
Modifications
Install the
pkg-configdependency.Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)