-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TableView-2] Implement all interfaces. #196
Conversation
Hi @BewareMyPower, Thanks for your reviews. All comments have been fixed, PTAL. |
@RobertIndie @BewareMyPower ping. |
Should we close #89 now? |
Hi @shibd, thanks for introducing this great feature! ======================================== As we discussed just now, for the doc side: ✅ Pulsar feature matrixI've ticked the boxes of "Table View" for C++. ✅ Pulsar client docs🌈 Collobration wayTo add docs for it, feel free to choose your preferred method (either way works for me):
🌈 TO-DO tasksThis doc is added to 5 doc versions (NEXT, 2.11.x, 2.10.x, 2.9.x, 2.8.x) since this feature is available from Pulsar 2.8.x. We can update one version first and apply the same doc changes to the rest once it gets approved. Task 1: use compacted topicsCreate a topic named "Use compacted topics" in work with table view. It should explain:
Task 2: register listenersTask 3: configure tableviewSimilarly, task 2 and task 3 have been explained in the image below. ======================================== Feel free to reach out to me if you have questions. TIA! |
Master Issue: #89
Motivation
#89
Modifications
TableView
.Verifying this change
TableViewTest
to cover all features.Documentation
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)