Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TableView-2] Implement all interfaces. #196

Merged
merged 3 commits into from
Mar 13, 2023
Merged

Conversation

shibd
Copy link
Member

@shibd shibd commented Feb 16, 2023

Master Issue: #89

Motivation

#89

Modifications

  • Implement all interfaces of TableView.

Verifying this change

  • Add TableViewTest to cover all features.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@shibd shibd added this to the 3.2.0 milestone Feb 16, 2023
@shibd shibd self-assigned this Feb 16, 2023
@shibd shibd added the enhancement New feature or request label Feb 16, 2023
lib/ClientImpl.cc Outdated Show resolved Hide resolved
lib/TableViewImpl.h Outdated Show resolved Hide resolved
lib/TableViewImpl.h Outdated Show resolved Hide resolved
lib/TableViewImpl.cc Show resolved Hide resolved
lib/TableViewImpl.cc Outdated Show resolved Hide resolved
lib/TableViewImpl.cc Outdated Show resolved Hide resolved
lib/TableViewImpl.cc Outdated Show resolved Hide resolved
lib/TableView.cc Outdated Show resolved Hide resolved
tests/TableViewTest.cc Outdated Show resolved Hide resolved
@shibd
Copy link
Member Author

shibd commented Mar 6, 2023

Hi @BewareMyPower, Thanks for your reviews. All comments have been fixed, PTAL.

@shibd shibd requested a review from BewareMyPower March 6, 2023 09:41
@shibd
Copy link
Member Author

shibd commented Mar 10, 2023

@RobertIndie @BewareMyPower ping.

lib/TableViewImpl.cc Outdated Show resolved Hide resolved
@BewareMyPower BewareMyPower merged commit 242ad77 into apache:main Mar 13, 2023
@BewareMyPower
Copy link
Contributor

Should we close #89 now?

@Anonymitaet
Copy link
Member

Anonymitaet commented Apr 18, 2023

Hi @shibd, thanks for introducing this great feature!

========================================

As we discussed just now, for the doc side:

✅ Pulsar feature matrix

I've ticked the boxes of "Table View" for C++.

✅ Pulsar client docs

🌈 Collobration way

To add docs for it, feel free to choose your preferred method (either way works for me):

  • You provide tech inputs to me. I'll write docs based on them and request your review. Or

  • You submit a PR to the pulsar-site repo directly and request my review.

🌈 TO-DO tasks

This doc is added to 5 doc versions (NEXT, 2.11.x, 2.10.x, 2.9.x, 2.8.x) since this feature is available from Pulsar 2.8.x.

  • Original doc file of NEXT is here.
  • Original doc files of all versioned docs are here.

We can update one version first and apply the same doc changes to the rest once it gets approved.

Task 1: use compacted topics

Create a topic named "Use compacted topics" in work with table view. It should explain:

  • What is it? (we already have this conceptual content, just add the link to this topic)
  • How to use it? (e.g., any considerations? Sample code, etc.)

Task 2: register listeners

Task 3: configure tableview

Similarly, task 2 and task 3 have been explained in the image below.

image

========================================

Feel free to reach out to me if you have questions. TIA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants