Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Support auto download schema when create producer. #157

Merged
merged 4 commits into from
Jan 19, 2023

Conversation

shibd
Copy link
Member

@shibd shibd commented Dec 26, 2022

Motivation

If a schema exists in a topic, but the producer does not know it. He still wanted to send data to the topic. (The scenario in which the DLQ sends a message: Please refer #139 [Verifying this change][5])

Modifications

  • When creating a producer with autoDownloadSchema param, try to get the schema of that topic and use it.
  • Support getSchema on LookupService(HTTP and Binary).

Verifying this change

  • Add LookupServiceTest unit test to cover getSchema logic.
  • Add SchemaTest.testAutoDownloadSchema unit test to cover creating producer success when the topic has a schema.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

lib/ClientConnection.cc Outdated Show resolved Hide resolved
lib/ClientConnection.cc Outdated Show resolved Hide resolved
lib/LookupService.h Show resolved Hide resolved
@shibd
Copy link
Member Author

shibd commented Jan 17, 2023

Job failure seems to have a flaky test, can help review and rerun the job? @BewareMyPower

@shibd shibd self-assigned this Jan 18, 2023
@shibd shibd added this to the 3.2.0 milestone Jan 18, 2023
lib/HTTPLookupService.cc Outdated Show resolved Hide resolved
tests/ClientTest.cc Outdated Show resolved Hide resolved
@BewareMyPower BewareMyPower merged commit 96507ce into apache:main Jan 19, 2023
@BewareMyPower BewareMyPower added the enhancement New feature or request label Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants