-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the broken master by the upgrade of GTest #133
Fix the broken master by the upgrade of GTest #133
Conversation
Maybe I have fixing the same problem. A fix is testing in erobot#4, have passed build but not complete ci yet. |
@erobot It seems to be a bug of gtest. I fixed it in another way (add an inline overload for const reference). Did you have any thought? |
@BewareMyPower I have a test that if change |
Not sure if it's a bug for GCC 11 or GTest itself. Let's continue this fix because it doesn't change the public API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
In another perspective, I'd prefer a fixed version of run-os
instead of latest
so that we explicit do the upgration on demand.
Agreed. I will modify it in this PR. |
I opened an issue here: google/googletest#4079. |
Now the tests work for Ubuntu 22.04 (GCC 11) but it failed for Ubuntu 20.04 (GCC 9) in my local env.
I decided to use another way to fix to avoid API changes. |
(cherry picked from commit 91a97eb)
Motivation
The
ubuntu:latest
image becameubuntu:22.04
after actions/runner-images#6399. The GTest is no longer compatible with the current code so the CI failed.Modifications
Pass
int
toTestWithParam
and stick the image version toubuntu-22.04
instead ofubuntu-latest
.