[fix] Fix NamedEntity::checkName regression #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
RobertIndie
approved these changes
Nov 28, 2022
shibd
approved these changes
Nov 28, 2022
RobertIndie
pushed a commit
to RobertIndie/pulsar-client-cpp
that referenced
this pull request
Nov 28, 2022
RobertIndie
pushed a commit
that referenced
this pull request
Dec 21, 2022
RobertIndie
pushed a commit
to streamnative/pulsar-client-cpp
that referenced
this pull request
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Namspace name with underscore is valid before but now invalid. This regression caused by #52.
Broker validates NamedEntity using regex
"^[-=:.\\w]*$", which actually includes the underscore. Although the comment sayingalphanumeric (a-za-z_0-9) and these special characters -=:is a bit confusing. But we should not break the actual validation rules used a long time ago.https://github.com/apache/pulsar/blob/355ba6002fc33b2716f59ca5d3a4fac667ecf3e1/pulsar-common/src/main/java/org/apache/pulsar/common/naming/NamedEntity.java#L30-L33
Modifications
Make underscore valid in NamedEntity.
Verifying this change
This change can covered by existing tests with some modifications, such as NamespaceNameTest.testNamespaceNameLegalCharacters and TopicNameTest.testLegalNonAlphaCharacters.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-neededfix regression only
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)