Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix PartitionedProducerImpl::closeAsync to close sub-producers properly #125

Merged
merged 10 commits into from
Nov 28, 2022
Merged

[fix] Fix PartitionedProducerImpl::closeAsync to close sub-producers properly #125

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7b0f82e
Fix PartitionedProducerImpl::closeAsync to close sub-producers properly
erobot Nov 25, 2022
4d85ce4
fix format
erobot Nov 25, 2022
bdb9069
Optimize code style
erobot Nov 28, 2022
5ee14d4
Add test ProducerTest.testCloseSubProducerWhenFail
erobot Nov 28, 2022
680f4d2
typo
BewareMyPower Nov 28, 2022
2e4fb57
correct typo
BewareMyPower Nov 28, 2022
50ea311
Update tests/ProducerTest.cc
erobot Nov 28, 2022
6ee6036
Update tests/ProducerTest.cc
erobot Nov 28, 2022
baa8ec2
address comment
erobot Nov 28, 2022
97b1cd5
remove PulsarFriend from test
erobot Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions lib/PartitionedProducerImpl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,13 +266,10 @@ void PartitionedProducerImpl::closeAsync(CloseCallback originalCallback) {
originalCallback(result);
}
};
if (state_ == Closed) {
closeCallback(ResultAlreadyClosed);
return;
}
State expectedState = Ready;
if (!state_.compare_exchange_strong(expectedState, Closing)) {
return;

State previous_state = state_.exchange(Closed);
if (previous_state == Closed) {
return closeCallback(ResultAlreadyClosed);
erobot marked this conversation as resolved.
Show resolved Hide resolved
}
erobot marked this conversation as resolved.
Show resolved Hide resolved

cancelTimers();
Expand Down