Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Failed to build the macOS wireshark plugin in CI #314

Closed
2 tasks done
BewareMyPower opened this issue Sep 11, 2023 · 1 comment · Fixed by #318
Closed
2 tasks done

[Bug] Failed to build the macOS wireshark plugin in CI #314

BewareMyPower opened this issue Sep 11, 2023 · 1 comment · Fixed by #318
Assignees
@BewareMyPower

Comments

@BewareMyPower
Copy link
Contributor

Search before asking

  • I searched in the issues and found nothing similar.

Version

Latest commit

Minimal reproduce step

https://github.com/apache/pulsar-client-cpp/actions/runs/6148375620/job/16681944089?pr=313

What did you expect to see?

CMake command succeeds.

What did you see instead?

-- Cannot find ws_version.h, fallback to find config.h
CMake Error at CMakeLists.txt:46 (message):
  Failed to find WIRESHARK_INCLUDE_PATH
-- Configuring incomplete, errors occurred!

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@BewareMyPower BewareMyPower mentioned this issue Sep 11, 2023
Merged
4 tasks
@BewareMyPower BewareMyPower self-assigned this Sep 13, 2023
@BewareMyPower
Copy link
Contributor Author

This issue requires an upstream fix. I pushed a PR in the homebrew repo: Homebrew/homebrew-core#142254

BewareMyPower added a commit to BewareMyPower/pulsar-client-cpp that referenced this issue Sep 19, 2023
@BewareMyPower
Fix broken wireshark build workflow on macOS
728ad4b 
Fixes apache#314

We need to run `brew update` to have the fix of
Homebrew/homebrew-core#142254 included.
@BewareMyPower BewareMyPower mentioned this issue Sep 19, 2023
Merged
shibd pushed a commit that referenced this issue Sep 19, 2023
@BewareMyPower
Fix broken wireshark build workflow on macOS (#318)
ba5902a 
Fixes #314

We need to run `brew update` to have the fix of
Homebrew/homebrew-core#142254 included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BewareMyPower BewareMyPower

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix broken wireshark build workflow on macOS BewareMyPower/pulsar-client-cpp
1 participant
@BewareMyPower