Avoid copying ConsumerStatsImpl or ProducerStatsImpl

apache · Mar 20, 2023 · adfedf6 · adfedf6
1 parent 8242c4b
commit adfedf6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/stats/ConsumerStatsImpl.cc b/lib/stats/ConsumerStatsImpl.cc
@@ -53,14 +53,15 @@ void ConsumerStatsImpl::flushAndReset(const boost::system::error_code& ec) {
     }
 
     Lock lock(mutex_);
-    ConsumerStatsImpl tmp = *this;
+    std::ostringstream oss;
+    oss << *this;
     numBytesRecieved_ = 0;
     receivedMsgMap_.clear();
     ackedMsgMap_.clear();
     lock.unlock();
 
     scheduleTimer();
-    LOG_INFO(tmp);
+    LOG_INFO(oss.str());
 }
 
 ConsumerStatsImpl::~ConsumerStatsImpl() { timer_->cancel(); }

diff --git a/lib/stats/ProducerStatsImpl.cc b/lib/stats/ProducerStatsImpl.cc
@@ -72,7 +72,8 @@ void ProducerStatsImpl::flushAndReset(const boost::system::error_code& ec) {
     }
 
     Lock lock(mutex_);
-    ProducerStatsImpl tmp = *this;
+    std::ostringstream oss;
+    oss << *this;
     numMsgsSent_ = 0;
     numBytesSent_ = 0;
     sendMap_.clear();
@@ -81,7 +82,7 @@ void ProducerStatsImpl::flushAndReset(const boost::system::error_code& ec) {
     lock.unlock();
 
     scheduleTimer();
-    LOG_INFO(tmp);
+    LOG_INFO(oss.str());
 }
 
 void ProducerStatsImpl::messageSent(const Message& msg) {